linux-kernel - Re: [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1909a09-f871-4c8b-825e-835605ff92a5@collabora.com>
Date: Fri, 13 Dec 2024 11:33:01 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Pin-yen Lin <treapking@...omium.org>,
 "Jason-JH.Lin" <jason-jh.lin@...iatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Singo Chang <singo.chang@...iatek.com>, Nancy Lin <nancy.lin@...iatek.com>,
 Shawn Sung <shawn.sung@...iatek.com>, dri-devel@...ts.freedesktop.org,
 linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com,
 Fei Shao <fshao@...omium.org>
Subject: Re: [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL
 compatible from MT8183 to MT8195

Il 13/12/24 11:26, Pin-yen Lin ha scritto:
> Hi Jason,
> 
> On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin <jason-jh.lin@...iatek.com> wrote:
>>
>> The OVL hardware capabilities have changed starting from MT8195,
>> making the MT8183 compatible no longer applicable.
>> Therefore, it is necessary to update the OVL compatible from MT8183 to
>> MT8195.
> 
> This probably doesn't need an (immediate) respin, but this patch needs:
> 
> Fixes: 7075b21d1a8e ("arm64: dts: mediatek: mt8188: Add display nodes
> for vdosys0")

No, because the binding must otherwise get a Fixes tag.

This is not a fix anyway, and is technically adding new features to the MT8188
OVL; without the additional features, the MT8188 is still compatible with the
MT8183 OVL, as much as MT8195.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

>>
>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
>> index faccc7f16259..23ec3ff6cad9 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
>> @@ -2488,7 +2488,7 @@ jpeg_decoder: jpeg-decoder@...40000 {
>>                  };
>>
>>                  ovl0: ovl@...00000 {
>> -                       compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8183-disp-ovl";
>> +                       compatible = "mediatek,mt8188-disp-ovl", "mediatek,mt8195-disp-ovl";
>>                          reg = <0 0x1c000000 0 0x1000>;
>>                          clocks = <&vdosys0 CLK_VDO0_DISP_OVL0>;
>>                          interrupts = <GIC_SPI 636 IRQ_TYPE_LEVEL_HIGH 0>;
>> --
>> 2.43.0
>>
> 
> Regards,
> Pin-yen