linux-kernel - Re: [PATCH v3] pinctrl: stm32: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN4iqtRk4g2q-1c3eTjELeKTTtfcV-MU-_36QkRa76+dsE4y1A@mail.gmail.com>
Date: Thu, 12 Dec 2024 20:13:07 -0500
From: Mingwei Zheng <zmw12306@...il.com>
To: Marek Vasut <marex@...x.de>
Cc: linus.walleij@...aro.org, mcoquelin.stm32@...il.com, 
	alexandre.torgue@...s.st.com, make24@...as.ac.cn, peng.fan@....com, 
	fabien.dessenne@...s.st.com, linux-gpio@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH v3] pinctrl: stm32: Add check for clk_enable()

Hi Marek,

On Sat, Dec 7, 2024 at 7:59 AM Marek Vasut <marex@...x.de> wrote:
>
> On 12/6/24 10:43 PM, Mingwei Zheng wrote:
>
> [...]
>
> > @@ -1646,8 +1645,8 @@ int stm32_pctl_probe(struct platform_device *pdev)
> >               if (ret) {
> >                       fwnode_handle_put(child);
> >
> > -                     for (i = 0; i < pctl->nbanks; i++)
> > -                             clk_disable_unprepare(pctl->banks[i].clk);
> > +                     clk_bulk_disable(pctl->nbanks, pctl->clks);
> > +                     clk_bulk_unprepare(pctl->nbanks, pctl->clks);
>
> Use clk_bulk_disable_unprepare()
>
> include/linux/clk.h:static inline void clk_bulk_disable_unprepare(int
> num_clks,

Thanks! We used clk_bulk_disable_unprepare() in the patch v4.

Best,
Mingwei

>
> It looks pretty good otherwise, thanks !