linux-kernel - Re: [PATCH v6] staging: gpib: Fix i386 build issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1wSIzBOZu4gUJhv@egonzo>
Date: Fri, 13 Dec 2024 11:53:23 +0100
From: Dave Penkler <dpenkler@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, dan.carpenter@...aro.org,
	geert@...ux-m68k.org, arnd@...nel.org
Subject: Re: [PATCH v6] staging: gpib: Fix i386 build issue

On Wed, Dec 11, 2024 at 11:42:36AM -0800, Guenter Roeck wrote:
> On 12/11/24 08:44, Dave Penkler wrote:
> > These drivers cast resource_type_t to void * causing the build to fail.
> > 
> > With a 32 bit build and PHYS_ADDR_T_64BIT enabled the resource_size_t
> > type is a 64bit unsigned int which cannot be cast to a 32 bit pointer.
> > 
> > Disable these drivers if not 64BIT and PHYS_ADDR_T_64BIT are configured.
> > 
> > Link: https://lore.kernel.org/linux-staging/2c6c7e9d-ca10-47a9-82a7-a2e26b1f51ef@roeck-us.net/
> > Reported-by: Guenter Roeck <linux@...ck-us.net>
> > Closes: https://lore.kernel.org/all/f10e976e-7a04-4454-b38d-39cd18f142da@roeck-us.net/
> > Fixes: e9dc69956d4d ("staging: gpib: Add Computer Boards GPIB driver")
> > Fixes: e1339245eba3 ("staging: gpib: Add Computer Equipment Corporation GPIB driver")
> > Fixes: bb1bd92fa0f2 ("staging: gpib: Add ines GPIB driver")
> > Fixes: 0cd5b05551e0 ("staging: gpib: Add TNT4882 chip based GPIB driver")
> > Signed-off-by: Dave Penkler <dpenkler@...il.com>
> 
> Tested-by: Guenter Roeck <linux@...ck-us.net>
> 
> Guenter
> 
Hi Guenter,
These nice patches from Arnd fix the i386 build issue without having applied 
my v6 patch:
Link: https://lore.kernel.org/linux-staging/20241213064959.1045243-1-arnd@kernel.org/

I tested only 
make ARCH=i386 allmodconfig
make ARCH=i386 M=drivers/staging/gpib

-Dave