linux-kernel - Re: [PATCH 1/2] dt-bindings: power: supply: gpio-charger: add support for default charge current limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4lef2r5lblj5waulkc56xbfa4xnlxbrk7rawdjgmkatgfnlj3z@vmtcvza6wcna>
Date: Fri, 13 Dec 2024 12:00:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
Cc: Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Dimitri Fedrau <dima.fedrau@...il.com>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: gpio-charger: add
 support for default charge current limit

On Wed, Dec 11, 2024 at 08:29:09AM +0100, Dimitri Fedrau wrote:
> Add binding for default charge current limit.

Why?

> 
> Signed-off-by: Dimitri Fedrau <dimitri.fedrau@...bherr.com>
> ---
>  Documentation/devicetree/bindings/power/supply/gpio-charger.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> index 89f8e2bcb2d7836c6a4308aff51721bd83fa3ba1..545fdd7133daf67b5bc238c5af26d0cbd8b44eae 100644
> --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> @@ -58,6 +58,10 @@ properties:
>              charge-current-limit-gpios property. Bit 1 second to last
>              GPIO and so on.
>  
> +  charge-current-limit-default:

Use standard property suffixes - see other bindings how they define
charge current.
git grep charge -- Documentation/devicetree/bindings/power/supply/

But what I don't get is why GPIO chager needs it, since this is
non-configurable for GPIO charger.

You have entire commit msg or property description to explain such
things.

Best regards,
Krzysztof