linux-kernel - Re: [PATCH v2 14/14] ASoC: qcom: sm8250: force single channel via RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58fefb90-a28b-4460-8837-14186d44ec1a@oss.qualcomm.com>
Date: Fri, 13 Dec 2024 12:57:44 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Alexey Klimov <alexey.klimov@...aro.org>,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>, broonie@...nel.org,
        konradybcio@...nel.org, andersson@...nel.org,
        srinivas.kandagatla@...aro.org
Cc: tiwai@...e.com, lgirdwood@...il.com, perex@...ex.cz, robh@...nel.org,
        krzk+dt@...nel.org, conor+dt@...nel.org, dmitry.baryshkov@...aro.org,
        linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 14/14] ASoC: qcom: sm8250: force single channel via
 RX_1 output for qrb4210

On 13.12.2024 12:54 PM, Alexey Klimov wrote:
> On Thu Dec 12, 2024 at 5:22 PM GMT, Konrad Dybcio wrote:
>> On 12.12.2024 1:47 AM, Alexey Klimov wrote:
>>> In case of mono configurations we need to enforce single channel
>>> output. This is required for audio playback on QRB4210 RB2 board
>>> since it has only one WSA8815 amplifier.
>>> Implement data variant for qrb4210-rb2-sndcard with
>>> sm8250_qrb4210_fixup_params() that does that.
>>>
>>> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>>> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
>>> ---
>>
>> Would it not be enough to set channels->min = 1?
> 
> Enough for what or to do what exactly?

Enough to make the rest of this patch unnecessary

Konrad