linux-kernel - Re: USB-C DisplayPort display failing to stay active with Intel Barlow Ridge USB4 controller, power-management related issue?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241213120329.GA2788819@black.fi.intel.com>
Date: Fri, 13 Dec 2024 14:03:29 +0200
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Aaron Rainbolt <arainbolt@...cus.org>
Cc: YehezkelShB@...il.com, michael.jamet@...el.com,
	andreas.noever@...il.com, linux-usb@...r.kernel.org,
	mmikowski@...cus.org, linux-kernel@...r.kernel.org,
	Gil Fine <gil.fine@...ux.intel.com>
Subject: Re: USB-C DisplayPort display failing to stay active with Intel
 Barlow Ridge USB4 controller, power-management related issue?

Hi Aaron,

On Thu, Dec 12, 2024 at 04:12:57PM -0600, Aaron Rainbolt wrote:
> On Fri, 15 Nov 2024 15:20:22 +0200
> Mika Westerberg <mika.westerberg@...ux.intel.com> wrote:
> 
> > Hi,
> > 
> > On Thu, Nov 14, 2024 at 10:41:25AM -0600, Aaron Rainbolt wrote:
> > > This is production hardware (specifically Clevo's X370SNW1-G and
> > > X370SNV1-G laptops), available for purchase from Sager, XOTICPC,
> > > Schenker, likely many other resellers, and our own website
> > > at https://kfocus.org/spec/spec-m2.html (with a tool that allows users
> > > to work around the bug). The firmware is baked into the hardware
> > > provided to us by our ODM, and for the sake of stability we do not
> > > modify any firmware on the machines with the exception of applying
> > > BIOS updates provided to us directly by the ODM. They appear to get
> > > their firmware directly from Clevo.  
> > 
> > Okay thanks.
> > 
> > > We have requested an updated BIOS from the ODM. If one is
> > > available, we will upgrade and run the tests again.  
> > 
> > Yes, I hope you can get the firmwares. The one you have now is not
> > "production quality" firmare so you should not really have that there
> > in the first place and Clevo should definitely provide you an
> > upgrade. Note this is separate from the BIOS. But your BIOS has issue
> > too regarding the USB4 power contract that is required by Microsoft
> > so I would expect that you should get that one upgraded too.
> > 
> > The patch I shared earlier should deal with all the other cases except
> > that weird one where we do not seem to get unplugs (and the resource
> > is available) which is not how the firmware is expected to work. I was
> > planning to submit it upstream after some more validation on our end,
> > probably afer v6.13-rc1 is released. I'll CC you.
> > 
> > If/when you get the new firmare I would definitely appreciate if your
> > folks could give it a try.
> 
> Hi Mika:
> 
> Just to catch you up: 
> We find the most recent patch from this thread to be a good improvement.
> 
> We tested it on our hardware with USB-C attached displays. In
> particular, it allows us to enable displays that do not time out while
> using with Thunderbolt. Without the patch, enabling the Thunderbolt
> kernel module would disable all attached USB-C displays in 15 seconds.
> 
> The patch does not resolve the hot plugging issue on our hardware, but
> we have a work-around for that (lspci -k or reloading the thunderbolt
> module). We have not been able to acquire new firmware yet, so this is
> likely the issue.
> 
> The test results are attached if you are interested.

Thanks for testing!

You probably noticed, I sent out a formal patch here:

https://lore.kernel.org/linux-usb/20241211103529.2302706-1-mika.westerberg@linux.intel.com/

You are Cc'd. I wonder if I can add your Tested-by tag to it?