linux-kernel - Re: [PATCH 3/3] staging: gpib: fix address space mixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1wx6pzVdh0y9w4d@egonzo>
Date: Fri, 13 Dec 2024 14:08:58 +0100
From: Dave Penkler <dpenkler@...il.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Rohit Chavan <roheetchavan@...il.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Prarit Bhargava <prarit@...hat.com>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: gpib: fix address space mixup

On Fri, Dec 13, 2024 at 07:49:51AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Throughout the gpib drivers, a 'void *' struct member is used in place
> of either port numbers or __iomem pointers, which leads to lots of extra
> type casts, sparse warnings and less portable code.
> 
> Split the struct member in two separate ones with the correct types,
> so each driver can pick which one to use.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  .../gpib/agilent_82350b/agilent_82350b.c      |  4 +-
>  drivers/staging/gpib/cb7210/cb7210.c          | 12 ++---
>  drivers/staging/gpib/cb7210/cb7210.h          |  4 +-
>  drivers/staging/gpib/cec/cec_gpib.c           |  4 +-
>  drivers/staging/gpib/common/gpib_os.c         |  2 +-
>  drivers/staging/gpib/eastwood/fluke_gpib.c    | 12 ++---
>  drivers/staging/gpib/eastwood/fluke_gpib.h    |  4 +-
>  drivers/staging/gpib/fmh_gpib/fmh_gpib.c      | 25 +++++-----
>  drivers/staging/gpib/fmh_gpib/fmh_gpib.h      |  4 +-
>  drivers/staging/gpib/hp_82335/hp82335.c       | 21 +++++----
>  drivers/staging/gpib/hp_82341/hp_82341.c      | 16 +++----
>  drivers/staging/gpib/include/gpib_types.h     |  3 +-
>  drivers/staging/gpib/include/nec7210.h        |  5 +-
>  drivers/staging/gpib/include/tms9914.h        |  5 +-
>  drivers/staging/gpib/ines/ines.h              |  4 +-
>  drivers/staging/gpib/ines/ines_gpib.c         | 22 ++++-----
>  .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c        |  2 +-
>  drivers/staging/gpib/nec7210/nec7210.c        | 16 +++----
>  drivers/staging/gpib/pc2/pc2_gpib.c           | 16 +++----
>  drivers/staging/gpib/tms9914/tms9914.c        |  8 ++--
>  drivers/staging/gpib/tnt4882/mite.h           |  4 +-
>  drivers/staging/gpib/tnt4882/tnt4882_gpib.c   | 46 +++++++++----------
>  22 files changed, 123 insertions(+), 116 deletions(-)
> 
[ skip ]
Hi Arnd,
Thank you so much for these valuable patches.
I have successfully tested them on the agilent and ni pci boards
on an amd x86_64 system.
This exercises the agilent_82350b, tms9914 and tnt4882 modules.
Your patches have also fixed the i386 build issue as far as I can tell.
Link: https://lore.kernel.org/all/f10e976e-7a04-4454-b38d-39cd18f142da@roeck-us.net/
cheers,
-Dave