linux-kernel - Re: [PATCH v2] soc: qcom: llcc: Enable LLCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1xAOQWFy2J7zbdC@hovoldconsulting.com>
Date: Fri, 13 Dec 2024 15:10:01 +0100
From: Johan Hovold <johan@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Sibi Sankar <quic_sibis@...cinc.com>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	Rajendra Nayak <quic_rjendra@...cinc.com>,
	Marijn Suijten <marijn.suijten@...ainline.org>,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v2] soc: qcom: llcc: Enable LLCC_WRCACHE at boot on X1

On Fri, Dec 13, 2024 at 01:24:24PM +0100, Konrad Dybcio wrote:
> On 13.12.2024 9:42 AM, Johan Hovold wrote:
> > On Thu, Dec 12, 2024 at 05:32:24PM +0100, Konrad Dybcio wrote:
> >> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> >>
> >> Do so in accordance with the internal recommendations.
> > 
> > Your commit message is still incomplete as it does not really say
> > anything about what this patch does, why this is needed or what the
> > implications are if not merging this patch.
> 
> I'm not sure I can say much more here..

If you don't know what this slice is used for or what impact enabling it
has then saying so in the commit message is also useful information.

But you should be able to provide some background for reviewers, stable
maintainers, other devs, posterity, ...

> > How would one determine that this patch is a valid candidate for
> > backporting, for example.
> 
> "suboptimal hw presets"

I'm sure the patch is correct, but spell something out in the commit
message.

Johan