linux-kernel - Re: [PATCH v3 20/23] arm64: dts: qcom: sdx75: Fix MPSS memory length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98fe04fb-8ae5-4fb6-91bd-3f9406efab02@oss.qualcomm.com>
Date: Fri, 13 Dec 2024 16:08:27 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Abel Vesa
 <abel.vesa@...aro.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Luca Weiss <luca.weiss@...rphone.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3 20/23] arm64: dts: qcom: sdx75: Fix MPSS memory length

On 13.12.2024 4:06 PM, Krzysztof Kozlowski wrote:
> On 13/12/2024 15:56, Konrad Dybcio wrote:
>> On 13.12.2024 3:54 PM, Krzysztof Kozlowski wrote:
>>> The address space in MPSS/Modem PAS (Peripheral Authentication Service)
>>> remoteproc node should point to the QDSP PUB address space
>>> (QDSP6...SS_PUB) which has a length of 0x10000.  Value of 0x4040 was
>>> copied from older DTS, but it grew since then.
>>>
>>> This should have no functional impact on Linux users, because PAS loader
>>> does not use this address space at all.
>>>
>>> Cc: stable@...r.kernel.org
>>> Fixes: 41c72f36b286 ("arm64: dts: qcom: sdx75: Add remoteproc node")
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>
>>> ---
>>>
>>> Changes in v3:
>>> New patch
>>> ---
>>>  arch/arm64/boot/dts/qcom/sdx75.dtsi | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>>> index 5f7e59ecf1ca6298cb252ee0654bc7eaeefbd303..a7cb6bacc4ad5551486d2ded930c1a256d27655e 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>>> @@ -893,7 +893,7 @@ tcsr: syscon@...0000 {
>>>  
>>>  		remoteproc_mpss: remoteproc@...0000 {
>>>  			compatible = "qcom,sdx75-mpss-pas";
>>> -			reg = <0 0x04080000 0 0x4040>;
>>> +			reg = <0 0x04080000 0 0x10000>;
>>
>> I think this should be 0x04400000 instead
> 
> 
> There are two QDSP6SS blocks - one at 0x0408_0000 and other you mention
> at 0x0440_0000 (MSS_VQ6). I think in all other DTS, e.g. SM8550, we
> describe the first, so 0x0408.

Ok right I looked at the wrong one

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad