linux-kernel - Re: [PATCH bpf-next v4 2/4] bpftool: btf: Validate root_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d702d19-3c73-4908-980a-248773abcae2@kernel.org>
Date: Fri, 13 Dec 2024 15:15:59 +0000
From: Quentin Monnet <qmo@...nel.org>
To: Daniel Xu <dxu@...uu.xyz>, andrii@...nel.org, ast@...nel.org,
 daniel@...earbox.net
Cc: martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
 yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
 sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, bpf@...r.kernel.org,
 linux-kernel@...r.kernel.org, andrii.nakryiko@...il.com, antony@...nome.org,
 toke@...nel.org
Subject: Re: [PATCH bpf-next v4 2/4] bpftool: btf: Validate root_type_ids
 early

2024-12-12 18:24 UTC-0700 ~ Daniel Xu <dxu@...uu.xyz>
> Handle invalid root_type_ids early, as an invalid ID will cause dumpers
> to half-emit valid boilerplate and then bail with an unclean exit. This
> is ugly and possibly confusing for users, so preemptively handle the
> common error case before any dumping begins.
> 
> Signed-off-by: Daniel Xu <dxu@...uu.xyz>


Reviewed-by: Quentin Monnet <qmo@...nel.org>