linux-kernel - Re: [PATCH] mm: fix outdated incorrect code comments for handle_mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qby7q5ghatldakzgayxr573g247pgoyuz2jkytbcnvwhas3mla@nvc4whogmnut>
Date: Fri, 13 Dec 2024 10:24:00 -0500
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Jinliang Zheng <alexjlzheng@...il.com>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Jinliang Zheng <alexjlzheng@...cent.com>
Subject: Re: [PATCH] mm: fix outdated incorrect code comments for
 handle_mm_fault()

* Jinliang Zheng <alexjlzheng@...il.com> [241212 22:18]:
> Signed-off-by: Jinliang Zheng <alexjlzheng@...cent.com>
> ---
>  mm/memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index d9af83dd86bb..d7342a726845 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -6159,7 +6159,8 @@ static vm_fault_t sanitize_fault_flags(struct vm_area_struct *vma,
>  }
>  
>  /*
> - * By the time we get here, we already hold the mm semaphore
> + * By the time we get here, we already hold either the VMA lock or the
> + * mmap_Lock (FAULT_FLAG_VMA_LOCK tells you which).
           ^ lower case here please, otherwise looking for mmap_lock
	   could fail. ie: grep mmap_lock..
>   *
>   * The mmap_lock may have been released depending on flags and our
>   * return value.  See filemap_fault() and __folio_lock_or_retry().
> -- 
> 2.41.1
> 
>