linux-kernel - Re: [PATCH net-next 07/12] xsk: add generic XSk &xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241213183118.2fdca6f1@kernel.org>
Date: Fri, 13 Dec 2024 18:31:18 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, John Fastabend <john.fastabend@...il.com>, "Andrii
 Nakryiko" <andrii@...nel.org>, Peter Zijlstra <peterz@...radead.org>, "Josh
 Poimboeuf" <jpoimboe@...nel.org>, "Jose E. Marchesi"
 <jose.marchesi@...cle.com>, Toke Høiland-Jørgensen
 <toke@...hat.com>, Magnus Karlsson <magnus.karlsson@...el.com>, "Maciej
 Fijalkowski" <maciej.fijalkowski@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Jason Baron <jbaron@...mai.com>, "Casey
 Schaufler" <casey@...aufler-ca.com>, Nathan Chancellor <nathan@...nel.org>,
 <nex.sw.ncis.osdt.itp.upstreaming@...el.com>, <bpf@...r.kernel.org>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 07/12] xsk: add generic XSk &xdp_buff -> skb
 conversion

On Fri, 13 Dec 2024 18:31:59 +0100 Alexander Lobakin wrote:
> > Can we kill all the if !CONFIG_PAGE_POOL sections and hide
> > the entire helper under if CONFIG_PAGE_POLL ?  
> 
> We can. But I think I'd need to introduce a return-NULL wrapper in case
> of !PAGE_POOL to satisfy the linker, as lots of drivers build their XSk
> code unconditionally.

Oh wow, you're right. Bunch of drivers of a certain vendor still don't
use page pool.. return NULL wrapped SGTM.