linux-kernel - [PATCH v2] mm: fix outdated incorrect code comments for handle_mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241214030050.1702776-1-alexjlzheng@tencent.com>
Date: Sat, 14 Dec 2024 11:00:50 +0800
From: Jinliang Zheng <alexjlzheng@...il.com>
To: akpm@...ux-foundation.org,
	Liam.Howlett@...cle.com
Cc: linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Jinliang Zheng <alexjlzheng@...cent.com>
Subject: [PATCH v2] mm: fix outdated incorrect code comments for handle_mm_fault()

Signed-off-by: Jinliang Zheng <alexjlzheng@...cent.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>
---
changelog:
- v2: lower case mmap_Lock to mmap_lock
- v1: https://lore.kernel.org/linux-mm/20241213031820.778342-1-alexjlzheng@tencent.com/#r
---
 mm/memory.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index d9af83dd86bb..9d64e02341f8 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -6159,7 +6159,8 @@ static vm_fault_t sanitize_fault_flags(struct vm_area_struct *vma,
 }
 
 /*
- * By the time we get here, we already hold the mm semaphore
+ * By the time we get here, we already hold either the VMA lock or the
+ * mmap_lock (FAULT_FLAG_VMA_LOCK tells you which).
  *
  * The mmap_lock may have been released depending on flags and our
  * return value.  See filemap_fault() and __folio_lock_or_retry().
-- 
2.41.1