linux-kernel - Re: [PATCH v8 3/3] crypto: Add Inside Secure SafeXcel EIP-93 crypto engine support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <675d88f1.7b0a0220.325e04.7513@mx.google.com>
Date: Sat, 14 Dec 2024 14:32:26 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: "David S. Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Antoine Tenart <atenart@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
	Waiman Long <longman@...hat.com>, Boqun Feng <boqun.feng@...il.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, linux-crypto@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev, upstream@...oha.com,
	Richard van Schagen <vschagen@...oud.com>
Subject: Re: [PATCH v8 3/3] crypto: Add Inside Secure SafeXcel EIP-93 crypto
 engine support

On Sat, Dec 14, 2024 at 12:37:22PM +0800, Herbert Xu wrote:
> On Wed, Dec 11, 2024 at 12:39:13PM +0100, Christian Marangi wrote:
> >
> > Do you have quick example for this?
> 
> Just search for crypto_ahash_set_reqsize in drivers/crypto and see
> how they use the reqctx to store temporary data.  For each request,
> you're guaranteed to have exclusive ownership of the reqctx.
> 
> If you wish to DMA into the reqctx, search for ahash_request_ctx_dma
> to see how you should set it up.
>

Oh ok I didn't understood you were referring to the request_ctx API
thanks.

I just pushed v9 with the requested changes done. Now we map DMA only
when needed and use local struct instead of kmalloc. kmalloc is only
used for blocks. For that GFP_ATOMIC is used. The ALLOCATES_MEMORY was
already set in the algo flags.

Hope I'm making good progress on this.

-- 
	Ansuel