linux-kernel - Re: [PATCH v1 0/3] Prefer evsel over evsel->core.idx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1zNuQaqtDDoQhP6@google.com>
Date: Fri, 13 Dec 2024 16:13:45 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz>,
	Chen Ni <nichen@...as.ac.cn>, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/3] Prefer evsel over evsel->core.idx

On Thu, Nov 14, 2024 at 03:07:10PM -0800, Ian Rogers wrote:
> James Clark's patches fixing evsel->core.idx [1] reminded me that we
> pass the int value around unnecessarily. Passing the evsel avoids
> issues if the evlist is reordered but paired with sanitizers we can
> also know when something is used when it shouldn't be. These patches
> do some initial work reducing the use of evsel->core.idx or reducing
> the API to pass evsels and not their interior index.
> 
> [1] https://lore.kernel.org/lkml/20241114160450.295844-2-james.clark@linaro.org/
> 
> Ian Rogers (3):
>   perf stream: Use evsel rather than evsel->idx
>   perf values: Use evsel rather than evsel->idx
>   perf annotate: Prefer passing evsel to evsel->core.idx

Reviewed-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> 
>  tools/perf/builtin-diff.c         |   4 +-
>  tools/perf/builtin-report.c       |   4 +-
>  tools/perf/builtin-top.c          |   4 +-
>  tools/perf/ui/browsers/annotate.c |   2 +-
>  tools/perf/util/annotate.c        |  32 +++++----
>  tools/perf/util/annotate.h        |  20 +++---
>  tools/perf/util/stream.c          |   7 +-
>  tools/perf/util/stream.h          |  10 +--
>  tools/perf/util/values.c          | 106 +++++++++++++-----------------
>  tools/perf/util/values.h          |   9 +--
>  10 files changed, 90 insertions(+), 108 deletions(-)
> 
> -- 
> 2.47.0.338.g60cca15819-goog
>