linux-kernel - Re: [PATCH 3/5] media: chips-media: wave5: Improve performance of decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd3fda36-7501-416c-9c02-3163c35a2edf@web.de>
Date: Sat, 14 Dec 2024 17:10:19 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jackson Lee <jackson.lee@...psnmedia.com>,
 Nas Chung <nas.chung@...psnmedia.com>, linux-media@...r.kernel.org,
 Dafna Hirschfeld <dafna.hirschfeld@...labora.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Robert Beckett <bob.beckett@...labora.com>,
 Sebastian Fricke <sebastian.fricke@...labora.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Brandon Brnich <b-brnich@...com>,
 Hans Verkuil <hverkuil-cisco@...all.nl>,
 Lafley Kim <lafley.kim@...psnmedia.com>
Subject: Re: [PATCH 3/5] media: chips-media: wave5: Improve performance of
 decoder

…
> Update driver to use an asynchronous approach for decoding and feeding a
> bitstream in order to achieve full capabilities of the device.
>
> Signed-off-by: Jackson.lee <jackson.lee@...psnmedia.com>
…

Does a dot really belong to a personal name (according to the Developer's Certificate of Origin?)
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc2#n436


…
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
…
> +static void wave5_vpu_dec_feed_remaining(struct vpu_instance *inst)
> +{
> +	int ret = 0;

May the initialisation be omitted for this local variable?


> +	struct v4l2_m2m_ctx *m2m_ctx = inst->v4l2_fh.m2m_ctx;
> +	u32 fail_res = 0;
> +
> +	mutex_lock(&inst->feed_lock);
> +	ret = fill_ringbuffer(inst);
> +	mutex_unlock(&inst->feed_lock);
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&inst->feed_lock);”?
https://elixir.bootlin.com/linux/v6.13-rc2/source/include/linux/mutex.h#L201

Regards,
Markus