linux-kernel - Re: [GIT PULL] SCSI fixes for 6.13-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjUTLUdiyc=+Mw3qTiQRu5xhtkBYd9r+o_hJTKgoW9XKQ@mail.gmail.com>
Date: Sat, 14 Dec 2024 16:02:47 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: James Bottomley <James.Bottomley@...senpartnership.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-scsi <linux-scsi@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] SCSI fixes for 6.13-rc2

On Sat, 14 Dec 2024 at 15:08, James Bottomley
<James.Bottomley@...senpartnership.com> wrote:
>
>       scsi: ufs: core: Update compl_time_stamp_local_clock after completing a cqe

Why does that ufs driver have that pointless "local_clock" version,
when it also does a real ktime?

It's documented to be just for debugging.

Then the "ktime" version is documented to be for statistics.

What makes this all make sense? Two different clocks, for two
different non-essential uses? And that duplication literally causes
bugs because clearly people get confused.

This particular bug has been around for almost two years, so equally
clearly these timestamps really *really* aren't that important.

Can we just agree that it's silly *and* confusing to maintain two
different completely unimportant timestamps in parallel, and just get
rid of at least one of them?

            Linus