linux-kernel - Re: [PATCH] usb: gadget: f_fs: remove unused values and add immediate returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024121557-alarm-devalue-c037@gregkh>
Date: Sun, 15 Dec 2024 12:52:49 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Karol P <karprzy7@...il.com>
Cc: paul@...pouillou.net, tudor.ambarus@...aro.org, Chris.Wulff@...mp.com,
	david.sands@...mp.com, viro@...iv.linux.org.uk,
	m.grzeschik@...gutronix.de, peter@...sgaard.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org
Subject: Re: [PATCH] usb: gadget: f_fs: remove unused values and add
 immediate returns

On Sun, Dec 15, 2024 at 12:41:03PM +0100, Karol P wrote:
> On Thu, 7 Nov 2024 at 06:15, Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Wed, Nov 06, 2024 at 07:30:32PM +0100, Karol Przybylski wrote:
> > > In case of faulty copy_from_user call inside ffs_epfile_ioctl, error code is
> > > saved in a variable. However, this variable is later overwritten in every possible
> > > path, which overshadows initial assignment.
> > >
> > > This patch fixes it by returning the error code immediately and exiting the function.
> > >
> > > Error discovered in coverity scan - CID 1583682
> > >
> > > Signed-off-by: Karol Przybylski <karprzy7@...il.com>
> > > ---
> > >  drivers/usb/gadget/function/f_fs.c | 9 +++------
> > >  1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > What commit id does this fix?
> 
> 7b07a2a7ca02a, usb: gadget: functionfs: Add DMABUF import interface

Then why not use the Fixes: tag?

> > How was this change tested?
> 
> I compiled the kernel and ran it on my machine.

Did you exercise this codepath?

> Are there other ways to reliably test such change?

Exercise the codepath by using the module and passing in a value to test
your change.

thanks,

greg k-h