linux-kernel - Re: [PATCH v3 1/1] dt-bindings: iio: pressure: bmp085: Add SPI interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241215122830.159555e1@jic23-huawei>
Date: Sun, 15 Dec 2024 12:28:30 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, ak@...klinger.de, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Krzysztof
 Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 1/1] dt-bindings: iio: pressure: bmp085: Add SPI
 interface

On Tue, 10 Dec 2024 00:38:45 +0100
Vasileios Amoiridis <vassilisamir@...il.com> wrote:

> The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it
> in the device-tree.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
Stray blank line at end of file.  I fixed that up and applied,

Thanks,

Jonathan

> ---
>  .../bindings/iio/pressure/bmp085.yaml         | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> index cb201cecfa1a..017abe8eb9c5 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> @@ -55,12 +55,16 @@ properties:
>        If not set, defaults to push-pull configuration.
>      type: boolean
>  
> +  spi-max-frequency:
> +    maximum: 10000000
> +
>  required:
>    - compatible
>    - vddd-supply
>    - vdda-supply
>  
>  allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
>    - if:
>        properties:
>          compatible:
> @@ -73,6 +77,16 @@ allOf:
>      then:
>        properties:
>          interrupts: false
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - bosch,bmp085
> +              - bosch,bmp180
> +    then:
> +      properties:
> +        spi-max-frequency: false
>  
>  additionalProperties: false
>  
> @@ -93,3 +107,19 @@ examples:
>              vdda-supply = <&bar>;
>          };
>      };
> +  - |
> +    # include <dt-bindings/gpio/gpio.h>
> +    # include <dt-bindings/interrupt-controller/irq.h>
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        pressure@0 {
> +            compatible = "bosch,bmp280";
> +            reg = <0>;
> +            spi-max-frequency = <10000000>;
> +            reset-gpios = <&gpio0 26 GPIO_ACTIVE_LOW>;
> +            vddd-supply = <&foo>;
> +            vdda-supply = <&bar>;
> +        };
> +    };
> +