linux-kernel - Re: [PATCH v7 3/4] sched, psi: Don't account irq time if sched_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALOAHbCpO-zeH1u5mQs9FvAP-V9JHf9G8LiQdbapDxoMMKzUhg@mail.gmail.com>
Date: Sun, 15 Dec 2024 21:38:33 +0800
From: Yafang Shao <laoar.shao@...il.com>
To: kernel test robot <lkp@...el.com>
Cc: mingo@...hat.com, peterz@...radead.org, mkoutny@...e.com, 
	hannes@...xchg.org, oe-kbuild-all@...ts.linux.dev, juri.lelli@...hat.com, 
	vincent.guittot@...aro.org, dietmar.eggemann@....com, rostedt@...dmis.org, 
	bsegall@...gle.com, mgorman@...e.de, vschneid@...hat.com, surenb@...gle.com, 
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org
Subject: Re: [PATCH v7 3/4] sched, psi: Don't account irq time if
 sched_clock_irqtime is disabled

On Sun, Dec 15, 2024 at 9:08 PM kernel test robot <lkp@...el.com> wrote:
>
> Hi Yafang,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on tip/sched/core]
> [also build test ERROR on peterz-queue/sched/core linus/master v6.13-rc2 next-20241213]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Yafang-Shao/sched-Define-sched_clock_irqtime-as-static-key/20241215-112638
> base:   tip/sched/core
> patch link:    https://lore.kernel.org/r/20241215032315.43698-4-laoar.shao%40gmail.com
> patch subject: [PATCH v7 3/4] sched, psi: Don't account irq time if sched_clock_irqtime is disabled
> config: arc-randconfig-001-20241215 (https://download.01.org/0day-ci/archive/20241215/202412152009.HZ862kna-lkp@intel.com/config)
> compiler: arc-elf-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241215/202412152009.HZ862kna-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412152009.HZ862kna-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    In file included from kernel/sched/build_utility.c:96:
>    kernel/sched/psi.c: In function 'psi_show':
> >> kernel/sched/psi.c:1243:42: error: 'PSI_IRQ' undeclared (first use in this function); did you mean 'PSI_IO'?
>     1243 |         if (!irqtime_enabled() && res == PSI_IRQ)
>          |                                          ^~~~~~~
>          |                                          PSI_IO
>    kernel/sched/psi.c:1243:42: note: each undeclared identifier is reported only once for each function it appears in

Thanks for the report.
will update it as follows,

#ifdef CONFIG_IRQ_TIME_ACCOUNTING
        if (!irqtime_enabled() && res == PSI_IRQ)
                return -EOPNOTSUPP;
#endif

-- 
Regards
Yafang