linux-kernel - [PATCH net-next] hippi: Remove unused hippi_neigh_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241215022618.181756-1-linux@treblig.org>
Date: Sun, 15 Dec 2024 02:26:18 +0000
From: linux@...blig.org
To: jes@...ined-monkey.org,
	andrew+netdev@...n.ch,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	horms@...nel.org
Cc: linux-hippi@...site.dk,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Dr. David Alan Gilbert" <linux@...blig.org>
Subject: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

From: "Dr. David Alan Gilbert" <linux@...blig.org>

hippi_neigh_setup_dev() has been unused since
commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")

Remove it.

(I'm a little suspicious it's the only setup call removed
by that previous commit?)

Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
---
 include/linux/hippidevice.h |  1 -
 net/802/hippi.c             | 15 ---------------
 2 files changed, 16 deletions(-)

diff --git a/include/linux/hippidevice.h b/include/linux/hippidevice.h
index 07414c241e65..404bd5b2b4fc 100644
--- a/include/linux/hippidevice.h
+++ b/include/linux/hippidevice.h
@@ -33,7 +33,6 @@ struct hippi_cb {
 
 __be16 hippi_type_trans(struct sk_buff *skb, struct net_device *dev);
 int hippi_mac_addr(struct net_device *dev, void *p);
-int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p);
 struct net_device *alloc_hippi_dev(int sizeof_priv);
 #endif
 
diff --git a/net/802/hippi.c b/net/802/hippi.c
index 1997b7dd265e..5e02ec1274a1 100644
--- a/net/802/hippi.c
+++ b/net/802/hippi.c
@@ -126,21 +126,6 @@ int hippi_mac_addr(struct net_device *dev, void *p)
 }
 EXPORT_SYMBOL(hippi_mac_addr);
 
-int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p)
-{
-	/* Never send broadcast/multicast ARP messages */
-	NEIGH_VAR_INIT(p, MCAST_PROBES, 0);
-
-	/* In IPv6 unicast probes are valid even on NBMA,
-	* because they are encapsulated in normal IPv6 protocol.
-	* Should be a generic flag.
-	*/
-	if (p->tbl->family != AF_INET6)
-		NEIGH_VAR_INIT(p, UCAST_PROBES, 0);
-	return 0;
-}
-EXPORT_SYMBOL(hippi_neigh_setup_dev);
-
 static const struct header_ops hippi_header_ops = {
 	.create		= hippi_header,
 };
-- 
2.47.1