linux-kernel - Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMF+KeZAGPYLjWujOpOk5esuX5XTFXzWgUx+baTrTskQ=jWqFA@mail.gmail.com>
Date: Sun, 15 Dec 2024 15:41:11 +0100
From: Joshua Grisham <josh@...huagrisham.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Joshua Grisham <josh@...huagrisham.com>, ilpo.jarvinen@...ux.intel.com, 
	hdegoede@...hat.com, platform-driver-x86@...r.kernel.org, corbet@....net, 
	linux-doc@...r.kernel.org, jdelvare@...e.com, linux-hwmon@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver

Den mån 9 dec. 2024 kl 17:58 skrev Guenter Roeck <linux@...ck-us.net>:
>
> > +             if (channel < galaxybook_ptr->fans_count && attr == hwmon_fan_input) {
> Why is this check necesary ? The is_visible function should have masked it out.
>
> > [...]
> Same as above.
>
> Guenter
>
> > [...]

Hi Guenter, now I have removed all of this from the v2 patch for this
driver and instead will pursue support for these fan devices directly
within ACPI instead! Thank you for taking a look!

Best,
Joshua