linux-kernel - Re: [PATCH v2 0/5] Move kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17476947-d447-4de3-87bb-97d5f3c0497d@suse.cz>
Date: Sun, 15 Dec 2024 18:30:02 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: "Uladzislau Rezki (Sony)" <urezki@...il.com>, linux-mm@...ck.org,
 "Paul E . McKenney" <paulmck@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: RCU <rcu@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
 Christoph Lameter <cl@...ux.com>, Pekka Enberg <penberg@...nel.org>,
 David Rientjes <rientjes@...gle.com>, Joonsoo Kim <iamjoonsoo.kim@....com>,
 Roman Gushchin <roman.gushchin@...ux.dev>,
 Hyeonggon Yoo <42.hyeyoo@...il.com>,
 Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [PATCH v2 0/5] Move kvfree_rcu() into SLAB (v2)

On 12/12/24 19:02, Uladzislau Rezki (Sony) wrote:
> Hello!
> 
> This is v2. It is based on the Linux 6.13-rc2. The first version is
> here:
> 
> https://lore.kernel.org/linux-mm/20241210164035.3391747-4-urezki@gmail.com/T/
> 
> The difference between v1 and v2 is that, the preparation process is
> done in original place instead and after that there is one final move.

Looks good, will include in slab/for-next

I think patch 5 should add more explanation to the commit message - the
subthread started by Christoph could provide content :) Can you summarize so
I can amend the commit log?

Also how about a followup patch moving the rcu-tiny implementation of
kvfree_call_rcu()?

We might also consider moving the kfree_rcu*() entry points from rcupdate.h
to slab.h, what do you think, is it a more logical place for them? There's
some risk that files that include rcupdate.h and not slab.h would break, so
that will need some build testing...

Thanks,
Vlastimil

> Uladzislau Rezki (Sony) (5):
>   rcu/kvfree: Initialize kvfree_rcu() separately
>   rcu/kvfree: Move some functions under CONFIG_TINY_RCU
>   rcu/kvfree: Adjust names passed into trace functions
>   rcu/kvfree: Adjust a shrinker name
>   mm/slab: Move kvfree_rcu() into SLAB
> 
>  include/linux/slab.h |   1 +
>  init/main.c          |   1 +
>  kernel/rcu/tree.c    | 876 ------------------------------------------
>  mm/slab_common.c     | 880 +++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 882 insertions(+), 876 deletions(-)
>