linux-kernel - [PATCH] tty: mark ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241215-tty-sysctl-const-v1-1-96884e456126@gmail.com>
Date: Sun, 15 Dec 2024 16:30:25 -0500
From: Luis Felipe Hernandez <luis.hernandez093@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Jiri Slaby <jirislaby@...nel.org>
Cc: Thomas Weißschuh <linux@...ssschuh.net>, 
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
 "Ricardo B. Marliere" <rbm@...e.com>, 
 Luis Felipe Hernandez <luis.hernandez093@...il.com>
Subject: [PATCH] tty: mark ctl_table as const

Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
ctl_table"), the sysctl registration API allows struct ctl_table variables
to be placed into read-only memory.

tty_table is registered as a sysctl table and should be treated as
read-only. By declaring the tty_table structure as const, we ensure that it
cannot be accidentally modified at runtime. This change improves safety
and aligns with the recommendation from commit 7abc9b53bd51 ("sysctl: allow
registration of const struct ctl_table").

Cc: Thomas Weißschuh <linux@...ssschuh.net>
Suggested-by: Thomas Weißschuh <linux@...ssschuh.net>
Suggested-by: Ricardo B. Marliere <rbm@...e.com>
Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@...il.com>
---
 drivers/tty/tty_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index dcb1769c3625cd0f7d1555260adfe6051139a305..0e84677712b4e1eb72f209c4d9c54a940b3a9041 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -3618,7 +3618,7 @@ void console_sysfs_notify(void)
 		sysfs_notify(&consdev->kobj, NULL, "active");
 }

-static struct ctl_table tty_table[] = {
+static const struct ctl_table tty_table[] = {
 	{
 		.procname	= "legacy_tiocsti",
 		.data		= &tty_legacy_tiocsti,

---
base-commit: 535a07698b8b3e6f305673102d297262cae2360a
change-id: 20241206-tty-sysctl-const-2e4b37b1875b

Best regards,
-- 
Luis Felipe Hernandez <luis.hernandez093@...il.com>