linux-kernel - Re: [PATCH v2] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMF+KeaPXojdGsT1--pa+nvAsbqk6_vFnZjGW4Dcgsfr8+gHZA@mail.gmail.com>
Date: Sun, 15 Dec 2024 23:51:14 +0100
From: Joshua Grisham <josh@...huagrisham.com>
To: Armin Wolf <W_Armin@....de>
Cc: Joshua Grisham <josh@...huagrisham.com>, corbet@....net, hdegoede@...hat.com, 
	ilpo.jarvinen@...ux.intel.com, jdelvare@...e.com, linux@...ck-us.net, 
	platform-driver-x86@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: samsung-galaxybook: Add
 samsung-galaxybook driver

Den sön 15 dec. 2024 kl 21:02 skrev Armin Wolf <W_Armin@....de>:
>
> The dell-wmi-ddv driver does manage his battery extension without any global variables.
> Could it be that you confused it with another Dell driver?
>

Yes I think I was looking at another one, but have reviewed
dell-wmi-ddv and it was very similar to what I had done. I will adjust
samsung-galaxybook just a bit more so it is closer to what is already
in dell-wmi-ddv (e.g. use a normal device_attribute without the
extended var and use that with container_of to fetch my private data).
Thank you!

> Please submit this v2 patch as its own separate patch as described in
> https://docs.kernel.org/process/submitting-patches.html ("The canonical patch format").
>
> If you use "git send-email", you can use the -v2 option to automatically adjust the patch
> header.
>
> You can describe the changes you made like this:
>
>      <commit message>
>      ...
>      Signed-off-by: Author <author@...l>
>      ---
>      V1 -> V2:
>      - <description of changes>
>      - ...
>
>      path/to/file | 5+++--
>      ...
>
> Thanks,
> Armin Wolf
>

Thank you both Armin and Guenter for highlighting this! I did in fact
use "git send-email" but did not check the contents of the patch file
(other than running the check script and resolving various issues it
reported) to ensure it looked ok -- lesson learned and I will submit a
v3 (including above-mentioned changes) of the patch shortly or
possibly tomorrow :)

Cheers!

Best regards,
Joshua