linux-kernel - Re: [PATCH net-next] net: dsa: qca8k: Fix inconsistent use of jiffies vs milliseconds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241215231334.imva5oorpyq7lavl@skbuf>
Date: Mon, 16 Dec 2024 01:13:34 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Christian Marangi <ansuelsmth@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: qca8k: Fix inconsistent use of
 jiffies vs milliseconds

On Sun, Dec 15, 2024 at 05:43:55PM +0000, Andrew Lunn wrote:
> wait_for_complete_timeout() expects a timeout in jiffies. With the
> driver, some call sites converted QCA8K_ETHERNET_TIMEOUT to jiffies,
> others did not. Make the code consistent by changes the #define to
> include a call to msecs_to_jiffies, and remove all other calls to
> msecs_to_jiffies.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---

If my calculations are correct, for CONFIG_HZ=100, 5 jiffies last 50 ms.
So, assuming that configuration, the patch would be _decreasing_ the timeout
from 50 ms to 5 ms. The change should be tested to confirm it's enough.
Christian, could you do that?