linux-kernel - Re: [PATCH] staging: gpib: Workaround for ppc build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6102c6b-693f-4237-8c0c-83c5936aab3c@roeck-us.net>
Date: Sun, 15 Dec 2024 15:23:55 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Dave Penkler <dpenkler@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, sfr@...b.auug.org.au
Subject: Re: [PATCH] staging: gpib: Workaround for ppc build failure

On Wed, Dec 04, 2024 at 02:47:36PM +0100, Dave Penkler wrote:
> Make GPIB_FMH depend on !PPC
> 
> Reported_by: Stephen Rothwell <sfr@...b.auug.org.au>
> Link: https://lore.kernel.org/all/20241015165538.634707e5@canb.auug.org.au/
> 
> Signed-off-by: Dave Penkler <dpenkler@...il.com>

This patch just exposes other build failures, for example
i386:allyesconfig or x86_64:allyesconfig.

Error log:
x86_64-linux-ld: vmlinux.o: in function `fmh_gpib_t1_delay':
fmh_gpib.c:(.text+0xfd49dbd): undefined reference to `nec7210_t1_delay'

There are many more missing functions. FWIW, I don't know how this is
supposed to work in the first place, since pretty much all gpib Makefiles
say

obj-m += <object file>

meaning they won't be built with allyesconfig. fmh_gpib is the only
exception with

obj-$(CONFIG_GPIB_FMH) += fmh_gpib.o

which means it _will_ be built with allyesconfig. So it is not surprising
that it fails to link allyesconfig builds. Actually, it will fail all builds
with CONFIG_GPIB_FMH=y.

Guenter