linux-kernel - Re: [PATCH 2/8] dmaengine: fsl-edma: remove FSL_EDMA_DRV_SPLIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2BSfW+YO6/3YXTn@lizhi-Precision-Tower-5810>
Date: Mon, 16 Dec 2024 11:17:01 -0500
From: Frank Li <Frank.li@....com>
To: Larisa Grigore <larisa.grigore@....nxp.com>
Cc: dmaengine@...r.kernel.org, imx@...ts.linux.dev,
	linux-kernel@...r.kernel.org, s32@....com,
	Christophe Lizzi <clizzi@...hat.com>,
	Alberto Ruiz <aruizrui@...hat.com>,
	Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH 2/8] dmaengine: fsl-edma: remove FSL_EDMA_DRV_SPLIT_REG
 check when parsing muxbase

On Mon, Dec 16, 2024 at 09:58:12AM +0200, Larisa Grigore wrote:
> Clean up dead code. dmamuxs is always 0 when FSL_EDMA_DRV_SPLIT_REG set. So
> it is redundant to check FSL_EDMA_DRV_SPLIT_REG again in the for loop
> because it will never enter for loop.
>
> Signed-off-by: Larisa Grigore <larisa.grigore@....nxp.com>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
>  drivers/dma/fsl-edma-main.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 2a7d19f51287..9873cce00c68 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -517,10 +517,6 @@ static int fsl_edma_probe(struct platform_device *pdev)
>  	for (i = 0; i < fsl_edma->drvdata->dmamuxs; i++) {
>  		char clkname[32];
>
> -		/* eDMAv3 mux register move to TCD area if ch_mux exist */
> -		if (drvdata->flags & FSL_EDMA_DRV_SPLIT_REG)
> -			break;
> -
>  		fsl_edma->muxbase[i] = devm_platform_ioremap_resource(pdev,
>  								      1 + i);
>  		if (IS_ERR(fsl_edma->muxbase[i])) {
> --
> 2.47.0
>