linux-kernel - Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2BZ7d1ojV5Gbdu1@gallifrey>
Date: Mon, 16 Dec 2024 16:48:45 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Simon Horman <horms@...nel.org>
Cc: jes@...ined-monkey.org, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	linux-hippi@...site.dk, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

* Simon Horman (horms@...nel.org) wrote:
> On Sun, Dec 15, 2024 at 02:26:18AM +0000, linux@...blig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > 
> > hippi_neigh_setup_dev() has been unused since
> > commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")
> > 
> > Remove it.
> > 
> > (I'm a little suspicious it's the only setup call removed
> > by that previous commit?)
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> 
> Hi David,
> 
> There is a dangling comment referring to hippi_neigh_setup_dev
> in hippi_setup().
> 
> 	/*
> 	 * HIPPI doesn't support broadcast+multicast and we only use
> 	 * static ARP tables. ARP is disabled by hippi_neigh_setup_dev.
> 	 */
> 
> Could you fix that up too?

I saw that, and it raised the suspicion that I mentioned in the
commit message; is that code relying on the uncalled, removed
function to disable ARPs?

Dave

> pw-bot: changes-requested
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/