linux-kernel - Re: [PATCH v2] net: ip6: ndisc: fix incorrect forwarding of proxied ns packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241216170129.531313-1-mail@florommel.de>
Date: Mon, 16 Dec 2024 18:01:29 +0100
From: Florian Rommel <mail@...rommel.de>
To: nils@...sfuhler.de
Cc: davem@...emloft.net,
	dsahern@...nel.org,
	edumazet@...gle.com,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	mail@...rommel.de
Subject: Re: [PATCH v2] net: ip6: ndisc: fix incorrect forwarding of proxied ns packets

What is the status of this? The proposed fix seems to work.

> > I have mixed feeling WRT this patch. It looks like a fix, but it's changing an established behaviour that is there since a lot of time.
> >
> > I think it could go via the net-next tree, without fixes
> > tag to avoid stable backports. As such I guess it deserves a self-test script validating the new behavior.
> >
> That is probably the best option.
> Although I'm not sure whether it would really break something. The
> forwarded packets have a hoplimit of 254 and are therefore not valid
> ndisc packets anymore.

I also can't imagine that anything depends on invalid packets being created?