linux-kernel - Re: [PATCH] drm/msm: fix -Wformat-security warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99148f0a-e46c-47a7-a910-12269817a0e6@quicinc.com>
Date: Mon, 16 Dec 2024 09:21:53 -0800
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Arnd Bergmann <arnd@...nel.org>, Rob Clark <robdclark@...il.com>,
        "Dmitry
 Baryshkov" <dmitry.baryshkov@...aro.org>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Jessica Zhang <quic_jesszhan@...cinc.com>
CC: Arnd Bergmann <arnd@...db.de>, Sean Paul <sean@...rly.run>,
        Konrad Dybcio
	<konradybcio@...nel.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Akhil P Oommen <quic_akhilpo@...cinc.com>,
        Neil Armstrong
	<neil.armstrong@...aro.org>,
        Jinjie Ruan <ruanjinjie@...wei.com>,
        Barnabás Czémán <barnabas.czeman@...nlining.org>,
        <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm: fix -Wformat-security warnings



On 12/16/2024 12:33 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Passing a variable string as a printf style format is potentially
> dangerous that -Wformat-security can warn about if enabled. A new
> instance just got added:
> 
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: In function 'dpu_kms_mdp_snapshot':
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:1046:49: error: format not a string literal and no format arguments [-Werror=format-security]
>   1046 |                                             vbif->name);
>        |                                             ~~~~^~~~~~
> 
> Fix this one and the preexisting -Wformat-security warnings the in the
> DRM code for snapdragon.
> 
> Fixes: 1a40bb31fcf1 ("drm/msm/dpu: Add VBIF to DPU snapshot") # and others
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> I have a larger series that I still plan to send eventually, sending this
> one now as I just saw another one get added. The warning is enabled by
> default because there are still over 100 other files with the same problem.
> ---
>   drivers/gpu/drm/msm/adreno/a6xx_gmu.c   |  2 +-
>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 28 ++++++++++++++++---------
>   2 files changed, 19 insertions(+), 11 deletions(-)
> 

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>