linux-kernel - Re: [PATCH V4] Input: bbnsm_pwrkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2BkdFHZnj-pDOoN@google.com>
Date: Mon, 16 Dec 2024 09:33:40 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: Frank.Li@....com, ping.bai@....com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH V4] Input: bbnsm_pwrkey - add remove hook

On Thu, Dec 12, 2024 at 11:03:22AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Without remove hook to clear wake irq, there will be kernel dump when
> doing module test.
> "bbnsm_pwrkey 44440000.bbnsm:pwrkey: wake irq already initialized"
> 
> Add remove hook to clear wake irq and set wakeup to false.
> 
> Fixes: 40e40fdfec3f ("Input: bbnsm_pwrkey - add bbnsm power key support")
> Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> 
> V4:
>  Fix build warning
> 
> V3:
>  I tried to dev_pm_clear_wake_irq in common code, but Greg rejected:
>  https://lore.kernel.org/all/2024111213-eradicate-puma-3592@gregkh/
>  So post v3 with input_unregister_device dropped

Greg did not reject the patch, he asked for a better justification.
Please answer his questions (we clear a lot of resources in remove() to
reduce boilerplate in the drivers), in the meantime I will apply this
patch to fix the pressing issue.

Thanks.

-- 
Dmitry