linux-kernel - Re: [PATCH V3] tools/perf/tests/shell/base_probe: Enhance print_overall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2BogUY4sx8mqrAg@x1>
Date: Mon, 16 Dec 2024 14:50:57 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: kajoljain <kjain@...ux.ibm.com>
Cc: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>, jolsa@...nel.org,
	adrian.hunter@...el.com, irogers@...gle.com, namhyung@...nel.org,
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, maddy@...ux.ibm.com,
	disgoel@...ux.vnet.ibm.com, mpetlan@...hat.com, vmolnaro@...hat.com
Subject: Re: [PATCH V3] tools/perf/tests/shell/base_probe: Enhance
 print_overall_results to print summary information

On Wed, Dec 11, 2024 at 05:33:50PM +0530, kajoljain wrote:
> On 12/6/24 19:22, Athira Rajeev wrote:
> > Here -a and -d doesn't require DWARF. Similarly there
> > are few other tests requiring DWARF. To hint the user that
> > missing dwarf could be one issue, update print_overall_results
> > to print a comment string along with summary hinting the possible
> > cause. Update test_invalid_options.sh and test_line_semantics.sh
> > to pass the info about dwarf requirement since these tests
> > failed when perf is built without DWARF. Use the check for
> > presence of dwarf with "perf check feature" and append the
> > hint message based on the result.
 
> Patch looks fine to me.
 
> Reviewed-by: kjain@...ux.ibm.com

Thanks, applied to perf-tools-next,

- Arnaldo