linux-kernel - Re: [PATCH v3 6/9] driver core: Rename declaration parameter name for API device_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2BrT8KEWdSSL12P@fan>
Date: Mon, 16 Dec 2024 10:02:55 -0800
From: Fan Ni <nifan.cxl@...il.com>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>, Tejun Heo <tj@...nel.org>,
	Josef Bacik <josef@...icpanda.com>, Jens Axboe <axboe@...nel.dk>,
	Boris Burkov <boris@....io>, Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	linux-block@...r.kernel.org, linux-cxl@...r.kernel.org,
	Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v3 6/9] driver core: Rename declaration parameter name
 for API device_find_child() cluster

On Thu, Dec 12, 2024 at 09:38:42PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> For APIs:
> device_find_child()
> device_for_each_child()
> device_for_each_child_reverse()
> 
> Their declaration has parameter name 'dev', but their defination
> changes the name to 'parent'.
> 
> Rename declaration name to defination 'parent' to make both have
> the same name.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>

Reviewed-by: Fan Ni <fan.ni@...sung.com>

> ---
>  include/linux/device.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 0e0bc9bfe0d15a8734bf3d34106300f4df6b5364..a9d928398895b062094b94f2c188cbe9951d7ac1 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -1074,14 +1074,14 @@ void device_del(struct device *dev);
>  
>  DEFINE_FREE(device_del, struct device *, if (_T) device_del(_T))
>  
> -int device_for_each_child(struct device *dev, void *data,
> +int device_for_each_child(struct device *parent, void *data,
>  			  int (*fn)(struct device *dev, void *data));
> -int device_for_each_child_reverse(struct device *dev, void *data,
> +int device_for_each_child_reverse(struct device *parent, void *data,
>  				  int (*fn)(struct device *dev, void *data));
>  int device_for_each_child_reverse_from(struct device *parent,
>  				       struct device *from, const void *data,
>  				       int (*fn)(struct device *, const void *));
> -struct device *device_find_child(struct device *dev, const void *data,
> +struct device *device_find_child(struct device *parent, const void *data,
>  				 device_match_t match);
>  struct device *device_find_child_by_name(struct device *parent,
>  					 const char *name);
> 
> -- 
> 2.34.1
> 

-- 
Fan Ni