linux-kernel - Re: [PATCH v2 2/4] dt-bindings: mfd: Add MDIO interface to rtl9301-switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <596c86d8-1cb3-434b-88d6-17ffe0fc9df2@alliedtelesis.co.nz>
Date: Tue, 17 Dec 2024 08:36:26 +1300
From: Chris Packham <chris.packham@...iedtelesis.co.nz>
To: Conor Dooley <conor@...nel.org>
Cc: lee@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, tsbogend@...ha.franken.de,
 hkallweit1@...il.com, linux@...linux.org.uk, markus.stockhausen@....de,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: mfd: Add MDIO interface to
 rtl9301-switch


On 17/12/2024 07:53, Conor Dooley wrote:
> On Mon, Dec 16, 2024 at 04:13:44PM +1300, Chris Packham wrote:
>> The MDIO controller is part of the switch on the RTL9300 family of
>> devices. Add a $ref to the mfd binding for these devices.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>>
>> Notes:
>>      Changes in v2:
>>      - None
>>
>>   .../bindings/mfd/realtek,rtl9301-switch.yaml      | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> index f053303ab1e6..eeb08e7435fa 100644
>> --- a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
>> @@ -41,6 +41,9 @@ patternProperties:
>>     'i2c@[0-9a-f]+$':
>>       $ref: /schemas/i2c/realtek,rtl9301-i2c.yaml#
>>   
>> +  'mdio@[0-9a-f]+$':
>> +    $ref: /schemas/net/realtek,rtl9301-mdio.yaml#
>> +
>>   required:
>>     - compatible
>>     - reg
>> @@ -110,5 +113,17 @@ examples:
>>             };
>>           };
>>         };
>> +
>> +      mdio0: mdio@...0 {
> Label here is unused, but that alone isn't worth a respin.
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>

I'll be re-spinning the series for other reasons so I'll fix this up and 
add your ack while I'm at it.

>
>> +        compatible = "realtek,rtl9301-mdio";
>> +        reg = <0xca00 0x200>;
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        ethernet-phy@0 {
>> +          reg = <0>;
>> +          realtek,smi-address = <0 1>;
>> +        };
>> +      };
>>       };
>>   
>> -- 
>> 2.47.1
>>