linux-kernel - [PATCH] bcachefs: Reverse first btree write conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241216193259.114315-1-sergio@lony.xyz>
Date: Mon, 16 Dec 2024 20:32:53 +0100
From: Sergio Miguéns Iglesias <sergio@...y.xyz>
To: kent.overstreet@...ux.dev
Cc: linux-bcachefs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Sergio Miguéns Iglesias <sergio@...y.xyz>
Subject: [PATCH] bcachefs: Reverse first btree write conditional

The conditional led nowhere so it was inverted to clean the code.

Signed-off-by: Sergio Miguéns Iglesias <sergio@...y.xyz>

---
 fs/bcachefs/btree_io.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/bcachefs/btree_io.c b/fs/bcachefs/btree_io.c
index 839d68802e42..7dbb1d908d94 100644
--- a/fs/bcachefs/btree_io.c
+++ b/fs/bcachefs/btree_io.c
@@ -1862,11 +1862,7 @@ static void btree_node_write_work(struct work_struct *work)
 		goto err;
 	}
 
-	if (wbio->wbio.first_btree_write) {
-		if (wbio->wbio.failed.nr) {
-
-		}
-	} else {
+	if (!wbio->wbio.first_btree_write) {
 		ret = bch2_trans_do(c,
 			bch2_btree_node_update_key_get_iter(trans, b, &wbio->key,
 					BCH_WATERMARK_interior_updates|
-- 
2.47.0