linux-kernel - Re: [PATCH] thermal/thresholds: Fix uapi header macros leading to a compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iJ1-sYxR8zEPa4YPEwrTXw+VxtUXnMEBhw2PJbLTueuQ@mail.gmail.com>
Date: Mon, 16 Dec 2024 21:31:54 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: rafael@...nel.org, Zhang Rui <rui.zhang@...el.com>, 
	Lukasz Luba <lukasz.luba@....com>, "open list:THERMAL" <linux-pm@...r.kernel.org>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thermal/thresholds: Fix uapi header macros leading to a
 compilation error

On Thu, Dec 12, 2024 at 9:13 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> The macros giving the direction of the crossing thresholds use the BIT
> macro which is not exported to the userspace. Consequently when an
> userspace program includes the header, it fails to compile.
>
> Replace the macros by their litteral to allow the compilation of
> userspace program using this header.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  include/uapi/linux/thermal.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/thermal.h b/include/uapi/linux/thermal.h
> index ba8604bdf206..349718c271eb 100644
> --- a/include/uapi/linux/thermal.h
> +++ b/include/uapi/linux/thermal.h
> @@ -3,8 +3,8 @@
>  #define _UAPI_LINUX_THERMAL_H
>
>  #define THERMAL_NAME_LENGTH    20
> -#define THERMAL_THRESHOLD_WAY_UP       BIT(0)
> -#define THERMAL_THRESHOLD_WAY_DOWN     BIT(1)
> +#define THERMAL_THRESHOLD_WAY_UP       0x1
> +#define THERMAL_THRESHOLD_WAY_DOWN     0x2
>
>  enum thermal_device_mode {
>         THERMAL_DEVICE_DISABLED = 0,
> --

Applied as 6.13-rc material, thanks!