linux-kernel - Re: [PATCH 09/10] x86/fpu: Remove unnecessary CPUID level check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1a133d4-ec9e-4857-ad24-cfdc7724d46f@intel.com>
Date: Mon, 16 Dec 2024 13:23:18 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: "Chang S. Bae" <chang.seok.bae@...el.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, linux-kernel@...r.kernel.org
Cc: x86@...nel.org, tglx@...utronix.de, bp@...en8.de, rafael@...nel.org,
 lenb@...nel.org, dave.jiang@...el.com, irenic.rajneesh@...il.com,
 david.e.box@...el.com
Subject: Re: [PATCH 09/10] x86/fpu: Remove unnecessary CPUID level check

On 12/16/24 11:05, Chang S. Bae wrote:
...> Then, the sanity check introduced in this code path appears redundant:
> 
> xsave_init()
> -> xstate_enable_boot_cpu()
>     -> setup_xstate_init()
>         -> setup_xstate_features()
> 
> Reviewed-by: Chang S. Bae <chang.seok.bae@...el.com>

Yeah, good point. Thanks for the review!

BTW, I do still want to make this into a _generic_ warning so that all
cpuid*() users get warned if they go reading leafs that are too high.
But I'll do that in another series.