linux-kernel - Re: [PATCH 0/4] firmware: google: Constify 'struct bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2ClAB6qY5LaMuHQ@google.com>
Date: Mon, 16 Dec 2024 14:09:04 -0800
From: Brian Norris <briannorris@...omium.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Tzung-Bi Shih <tzungbi@...nel.org>,
	Julius Werner <jwerner@...omium.org>,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] firmware: google: Constify 'struct bin_attribute'

On Sun, Dec 15, 2024 at 03:49:08PM +0100, Thomas Weißschuh wrote:
> The sysfs core now allows instances of 'struct bin_attribute' to be
> moved into read-only memory. Make use of that to protect them against
> accidental or malicious modifications.

I'm not in love with all these "_new" transformations that need a second
round of cleanup, but I'm not aware of any better way to do it.

For the series:

Acked-by: Brian Norris <briannorris@...omium.org>

> Please also note the remark at the end of the vpd patch.

I don't have much opinion on the options there. It seems like it's the
difference between an extra cleanup patch or two if we go with the
current series, vs. extra work for you with possible conflicts if we go
with your alternative.

Brian