linux-kernel - Re: [PATCH net-next] net: dsa: qca8k: Fix inconsistent use of jiffies vs milliseconds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f1c3d1f-8059-4038-bc2c-5729254a5b38@lunn.ch>
Date: Tue, 17 Dec 2024 00:08:51 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: qca8k: Fix inconsistent use of
 jiffies vs milliseconds

On Mon, Dec 16, 2024 at 08:55:13PM +0100, Christian Marangi wrote:
> On Mon, Dec 16, 2024 at 10:21:12AM +0100, Andrew Lunn wrote:
> > On Mon, Dec 16, 2024 at 01:13:34AM +0200, Vladimir Oltean wrote:
> > > On Sun, Dec 15, 2024 at 05:43:55PM +0000, Andrew Lunn wrote:
> > > > wait_for_complete_timeout() expects a timeout in jiffies. With the
> > > > driver, some call sites converted QCA8K_ETHERNET_TIMEOUT to jiffies,
> > > > others did not. Make the code consistent by changes the #define to
> > > > include a call to msecs_to_jiffies, and remove all other calls to
> > > > msecs_to_jiffies.
> > > > 
> > > > Signed-off-by: Andrew Lunn <andrew@...n.ch>
> > > > ---
> > > 
> > > If my calculations are correct, for CONFIG_HZ=100, 5 jiffies last 50 ms.
> > > So, assuming that configuration, the patch would be _decreasing_ the timeout
> > > from 50 ms to 5 ms. The change should be tested to confirm it's enough.
> > > Christian, could you do that?
> > 
> > I've have an qca8k system now, and have tested this patch. However, a
> > Tested-by: from Christian would be very welcome.
> >
> 
> Hi need 1-2 days to test this, hope that is O.K.

That is fine, I don't really expect the remaining patches will go
anywhere until next year, with net-next closing soon.

	Andrew