linux-kernel - Re: [PATCH v2 6/7] of: Fix potential wrong MODALIAS uevent value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412161436.p6lF8p6C-lkp@intel.com>
Date: Mon, 16 Dec 2024 15:02:10 +0800
From: kernel test robot <lkp@...el.com>
To: Zijun Hu <zijun_hu@...oud.com>, Rob Herring <robh@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Maxime Ripard <mripard@...nel.org>,
	Robin Murphy <robin.murphy@....com>,
	Grant Likely <grant.likely@...aro.org>
Cc: oe-kbuild-all@...ts.linux.dev, Zijun Hu <zijun_hu@...oud.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/7] of: Fix potential wrong MODALIAS uevent value

Hi Zijun,

kernel test robot noticed the following build errors:

[auto build test ERROR on 0f7ca6f69354e0c3923bbc28c92d0ecab4d50a3e]

url:    https://github.com/intel-lab-lkp/linux/commits/Zijun-Hu/of-Fix-API-of_find_node_opts_by_path-finding-OF-device-node-failure/20241216-084408
base:   0f7ca6f69354e0c3923bbc28c92d0ecab4d50a3e
patch link:    https://lore.kernel.org/r/20241216-of_core_fix-v2-6-e69b8f60da63%40quicinc.com
patch subject: [PATCH v2 6/7] of: Fix potential wrong MODALIAS uevent value
config: parisc-randconfig-002-20241216 (https://download.01.org/0day-ci/archive/20241216/202412161436.p6lF8p6C-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241216/202412161436.p6lF8p6C-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412161436.p6lF8p6C-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/clk-provider.h:9,
                    from lib/vsprintf.c:23:
   include/linux/of.h: In function 'of_modalias':
>> include/linux/of.h:764:16: error: returning 'int' from a function with return type 'char *' makes pointer from integer without a cast [-Wint-conversion]
     764 |         return -ENODEV;
         |                ^
   lib/vsprintf.c: In function 'va_format':
   lib/vsprintf.c:1683:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
    1683 |         buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
         |         ^~~
--
   In file included from lib/logic_pio.c:11:
   include/linux/of.h: In function 'of_modalias':
>> include/linux/of.h:764:16: error: returning 'int' from a function with return type 'char *' makes pointer from integer without a cast [-Wint-conversion]
     764 |         return -ENODEV;
         |                ^

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [y]:
   - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]


vim +764 include/linux/of.h

bd69f73f2c81ee Grant Likely  2013-02-10  761  
f1f6eae8bdfdfc Zijun Hu      2024-12-16  762  static inline char *of_modalias(const struct device_node *np, ssize_t *lenp)
bd7a7ed774afd1 Miquel Raynal 2023-04-04  763  {
bd7a7ed774afd1 Miquel Raynal 2023-04-04 @764  	return -ENODEV;
bd7a7ed774afd1 Miquel Raynal 2023-04-04  765  }
bd7a7ed774afd1 Miquel Raynal 2023-04-04  766  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki