linux-kernel - Re: [PATCH v1 1/5] dt-bindings: display: tegra: Add actmon information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262c8d8f-f53c-455b-9bca-3440afb7bcd6@kernel.org>
Date: Mon, 16 Dec 2024 08:26:36 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Johnny Liu <johnliu@...dia.com>
Cc: airlied@...il.com, conor+dt@...nel.org, devicetree@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, jonathanh@...dia.com, krzk+dt@...nel.org,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 linux-tegra@...r.kernel.org, luca.ceresoli@...tlin.com,
 maarten.lankhorst@...ux.intel.com, mperttunen@...dia.com,
 mripard@...nel.org, robh@...nel.org, simona@...ll.ch,
 skomatineni@...dia.com, thierry.reding@...il.com, tzimmermann@...e.de
Subject: Re: [PATCH v1 1/5] dt-bindings: display: tegra: Add actmon
 information

On 14/12/2024 00:29, Johnny Liu wrote:
>> On Tue, Dec 10, 2024 at 09:45:50AM -0800, Johnny Liu wrote:
>>> An activity monitor (actmon) is used to measure the device runtime
>>> utilization to help drive software power management policies.
>>>
>>> Extend the reg space to include actmon aperture for actmon configuration
>>> through host1x.
>>
>> We kind of see that from the diff. Say what we do not see, e.g. ABI
>> impact or why this is flexible/optional for existing devices.
> 
> Since actmon is not well-supported for the previous chips (e.g. T210,
> T186, T194, and etc) in this patch series, it's essential to make the
> specification of regs property optional for the previous chips.

Then your schema should express it.

> 
> Enablement/Disablement of actmon won't affect the host1x main functionality.
> Its main job is to monitor the engines behind the host1x and serve for
> telemetry purpose.
> 
> I could update the commit message to include the above reason. Please
> let me know if more information is required.

And fix the schema to make it optional only for older variants.


Best regards,
Krzysztof