linux-kernel - Re: [PATCH] USB: phy: tahvo: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024121649-dreadlock-undesired-d9de@gregkh>
Date: Mon, 16 Dec 2024 08:56:13 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Mingwei Zheng <zmw12306@...il.com>
Cc: u.kleine-koenig@...libre.com, aaro.koskinen@....fi, balbi@...com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jiasheng Jiang <jiashengjiangcool@...il.com>
Subject: Re: [PATCH] USB: phy: tahvo: Add check for clk_enable()

On Sun, Dec 15, 2024 at 04:00:06PM -0500, Mingwei Zheng wrote:
> Add check for the return value of clk_enable() to catch the potential
> error.
> 
> Fixes: 9ba96ae5074c ("usb: omap1: Tahvo USB transceiver driver")
> Signed-off-by: Mingwei Zheng <zmw12306@...il.com>
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
> ---
>  drivers/usb/phy/phy-tahvo.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index ae7bf3ff89ee..0b8801318cd2 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -342,8 +342,11 @@ static int tahvo_usb_probe(struct platform_device *pdev)
>  	mutex_init(&tu->serialize);
>  
>  	tu->ick = devm_clk_get(&pdev->dev, "usb_l4_ick");
> -	if (!IS_ERR(tu->ick))
> -		clk_enable(tu->ick);
> +	if (!IS_ERR(tu->ick)) {
> +		ret = clk_enable(tu->ick);
> +		if (ret)
> +			return ret;
> +	}

Same questions, why the signed-off-by order and how was this found and
tested?

thanks,

greg k-h