linux-kernel - Re: [PATCH] riscv: qspinlock: Fixup _Q_PENDING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4110cdab-7658-4820-a809-da326e4ad3e7@ghiti.fr>
Date: Mon, 16 Dec 2024 09:23:39 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: guoren@...nel.org, paul.walmsley@...ive.com, palmer@...belt.com,
 bjorn@...osinc.com, conor@...nel.org, leobras@...hat.com,
 peterz@...radead.org, parri.andrea@...il.com, will@...nel.org,
 longman@...hat.com, boqun.feng@...il.com, arnd@...db.de,
 alexghiti@...osinc.com
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH] riscv: qspinlock: Fixup _Q_PENDING_LOOPS definition

Hi Guo,

On 15/12/2024 14:52, guoren@...nel.org wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
>
> When CONFIG_RISCV_QUEUED_SPINLOCKS=y, the _Q_PENDING_LOOPS
> definition is missing. Add the _Q_PENDING_LOOPS definition for
> pure qspinlock usage.
>
> Fixes: ab83647fadae ("riscv: Add qspinlock support")
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@...nel.org>
> ---
>   arch/riscv/include/asm/spinlock.h | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/include/asm/spinlock.h b/arch/riscv/include/asm/spinlock.h
> index e5121b89acea..52f11bfd0079 100644
> --- a/arch/riscv/include/asm/spinlock.h
> +++ b/arch/riscv/include/asm/spinlock.h
> @@ -3,8 +3,11 @@
>   #ifndef __ASM_RISCV_SPINLOCK_H
>   #define __ASM_RISCV_SPINLOCK_H
>   
> -#ifdef CONFIG_RISCV_COMBO_SPINLOCKS
> +#ifdef CONFIG_QUEUED_SPINLOCKS
>   #define _Q_PENDING_LOOPS	(1 << 9)
> +#endif
> +
> +#ifdef CONFIG_RISCV_COMBO_SPINLOCKS
>   
>   #define __no_arch_spinlock_redefine
>   #include <asm/ticket_spinlock.h>


Yep, good catch!

Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex