linux-kernel - drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c:1638:5-8: Unneeded variable: "ret". Return "0" on line 1642

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202412161655.2LXuAggt-lkp@intel.com>
Date: Mon, 16 Dec 2024 16:35:55 +0800
From: kernel test robot <lkp@...el.com>
To: Likun Gao <Likun.Gao@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Alex Deucher <alexander.deucher@....com>,
	Kenneth Feng <kenneth.feng@....com>
Subject: drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c:1638:5-8:
 Unneeded variable: "ret". Return "0" on line 1642

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
commit: 3e55845c3983d92e28517a545e403b5eb9acf95b drm/amd/swsmu: add smu v14_0_2 support
date:   8 months ago
config: i386-randconfig-052-20241214 (https://download.01.org/0day-ci/archive/20241216/202412161655.2LXuAggt-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412161655.2LXuAggt-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c:1638:5-8: Unneeded variable: "ret". Return "0" on line 1642
   drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c:1647:5-8: Unneeded variable: "ret". Return "0" on line 1651
   drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c:1711:5-8: Unneeded variable: "ret". Return "0" on line 1715

vim +1638 drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c

  1635	
  1636	static int smu_v14_0_2_mode1_reset(struct smu_context *smu)
  1637	{
> 1638		int ret = 0;
  1639	
  1640		// TODO
  1641	
> 1642		return ret;
  1643	}
  1644	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki