linux-kernel - Re: [PATCH v3] leds: pwm-multicolor: Disable PWM when going to suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241216094943.GH2418536@google.com>
Date: Mon, 16 Dec 2024 09:49:43 +0000
From: Lee Jones <lee@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Jakob Riepler <jakob+lkml@...anoidlabs.org>,
	Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Uwe Kleine-König <uwe@...ine-koenig.org>,
	Jakob Riepler <jakob+lkml@...osfield.at>
Subject: Re: [PATCH v3] leds: pwm-multicolor: Disable PWM when going to
 suspend

On Sat, 14 Dec 2024, Uwe Kleine-König wrote:

> Hello Jakob,
> 
> On Fri, Dec 13, 2024 at 08:10:41PM +0100, Jakob Riepler wrote:
> > This fixes suspend on platforms like stm32mp1xx, where the PWM consumer
> > has to be disabled for the PWM to enter suspend.
> > Another positive side effect is that active-low LEDs now properly
> > turn off instead of going back to full brightness when they are set to 0.
> > 
> > Link: https://lore.kernel.org/all/20240417153846.271751-2-u.kleine-koenig@pengutronix.de/
> > Signed-off-by: Jakob Riepler <jakob+lkml@...osfield.at>
> > ---
> > Changes in v2:
> >  - fix wrong line-breaks in patch
> > Changes in v3:
> >  - use git send-email
> 
> Applies fine for me now.
> 
> I already gave my Ack for v2, repeating it here to make it easy to pick
> up:
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> 
> Please add this to your v4 if you have to send a new version. I don't
> know how picky Lee is, but the email address of the sender doesn't match
> the S-o-b line ...

Very picky!  Please resend.

Also, please send subsequent versions as a new thread.

-- 
Lee Jones [李琼斯]