linux-kernel - Re: [PATCH] tools/perf/arch/powerpc: Add register mask for power11 PVR in extended regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0402AAF0-5498-48C7-BEBA-2C0B7508D9E2@linux.vnet.ibm.com>
Date: Mon, 16 Dec 2024 15:32:12 +0530
From: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
To: kajoljain <kjain@...ux.ibm.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>, Ian Rogers <irogers@...gle.com>
Cc: acme@...nel.org, jolsa@...nel.org, adrian.hunter@...el.com,
        irogers@...gle.com, namhyung@...nel.org, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        maddy@...ux.ibm.com, disgoel@...ux.vnet.ibm.com,
        hbathini@...ux.ibm.com
Subject: Re: [PATCH] tools/perf/arch/powerpc: Add register mask for power11
 PVR in extended regs



> On 11 Dec 2024, at 5:32 PM, kajoljain <kjain@...ux.ibm.com> wrote:
> 
> 
> 
> On 12/6/24 19:26, Athira Rajeev wrote:
>> Perf tools side uses extended mask to display the platform
>> supported register names (with -I? option) to the user
>> and also send this mask to the kernel to capture the extended registers
>> as part of each sample. This mask value is decided based on
>> the processor version ( from PVR ).
>> 
>> Add PVR value for power11 to enable capturing the extended regs
>> as part of sample in power11.
> 
> Patch looks fine to me.
> 
> Reviewed-by: Kajol Jain <kjain@...ux.ibm.com>

Hi

Can we please pull in this patch if it looks fine.

Thanks
Athira
> 
> 
>> 
>> Signed-off-by: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>
>> ---
>> 
>> tools/perf/arch/powerpc/util/perf_regs.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/tools/perf/arch/powerpc/util/perf_regs.c b/tools/perf/arch/powerpc/util/perf_regs.c
>> index e8e6e6fc6f17..bd36cfd420a2 100644
>> --- a/tools/perf/arch/powerpc/util/perf_regs.c
>> +++ b/tools/perf/arch/powerpc/util/perf_regs.c
>> @@ -16,6 +16,7 @@
>> 
>> #define PVR_POWER9 0x004E
>> #define PVR_POWER10 0x0080
>> +#define PVR_POWER11 0x0082
>> 
>> static const struct sample_reg sample_reg_masks[] = {
>> SMPL_REG(r0, PERF_REG_POWERPC_R0),
>> @@ -207,7 +208,7 @@ uint64_t arch__intr_reg_mask(void)
>> version = (((mfspr(SPRN_PVR)) >>  16) & 0xFFFF);
>> if (version == PVR_POWER9)
>> extended_mask = PERF_REG_PMU_MASK_300;
>> - else if (version == PVR_POWER10)
>> + else if ((version == PVR_POWER10) || (version == PVR_POWER11))
>> extended_mask = PERF_REG_PMU_MASK_31;
>> else
>> return mask;
>