linux-kernel - Re: [PATCH v2] freezer, sched: report the frozen task stat as 'D'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe6728eb-d1a4-4e5d-a01c-9585452d0a79@huaweicloud.com>
Date: Mon, 16 Dec 2024 18:45:09 +0800
From: Chen Ridong <chenridong@...weicloud.com>
To: Tejun Heo <tj@...nel.org>
Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
 vincent.guittot@...aro.org, dietmar.eggemann@....com, rostedt@...dmis.org,
 bsegall@...gle.com, mgorman@...e.de, vschneid@...hat.com, mkoutny@...e.com,
 roman.gushchin@...ux.dev, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org, chenridong@...wei.com, wangweiyang2@...wei.com
Subject: Re: [PATCH v2] freezer, sched: report the frozen task stat as 'D'



On 2024/12/14 0:43, Tejun Heo wrote:
> On Fri, Dec 13, 2024 at 11:03:32AM +0000, Chen Ridong wrote:
> ...
>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>> index d380bffee2ef..dbe0cb97461f 100644
>> --- a/include/linux/sched.h
>> +++ b/include/linux/sched.h
>> @@ -1630,8 +1630,9 @@ static inline unsigned int __task_state_index(unsigned int tsk_state,
>>  	 * We're lying here, but rather than expose a completely new task state
>>  	 * to userspace, we can make this appear as if the task has gone through
>>  	 * a regular rt_mutex_lock() call.
>> +	 * Report the frozen task uninterruptible.
>>  	 */
>> -	if (tsk_state & TASK_RTLOCK_WAIT)
>> +	if (tsk_state & TASK_RTLOCK_WAIT || tsk_state & TASK_FROZEN)
> 
> Can you please add ()'s so that it's if ((a & b) || (c & d))? Other than
> that,
> 
> Acked-by: Tejun Heo <tj@...nel.org>
> 
> Thanks.
> 

Thanks, will update.