linux-kernel - Re: [PATCH 2/2] gpio: omap: save two lines by using devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7c3effb-a7e1-4a24-ac7e-f84e49eefb80@gmail.com>
Date: Mon, 16 Dec 2024 13:14:47 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>,
 "brgl@...ev.pl" <brgl@...ev.pl>
Cc: "bartosz.golaszewski@...aro.org" <bartosz.golaszewski@...aro.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: omap: save two lines by using
 devm_clk_get_prepared()

On 16/12/2024 13:11, Matti Vaittinen wrote:
> On 16/12/2024 10:57, Sverdlin, Alexander wrote:
...

> This fixes the boot as you assumed.
> I suppose this should be baked in the Bartosz's original patch assumed 
> it was dropped from the GPIO tree.
> 
> Furthermore, this seems to be a fix to a hidden problem on original 
> code.

Just a minor clarification:
"Original code" here refers to the code before the
"gpio: omap: save two lines by using devm_clk_get_prepared()"

> If the original code failed in the clk_prepare() and then deferred 
> probe(), this same problem should have appeared, right?
> 
> Maybe consider using Fixes - tag even if this and the original change 
> got squashed. Feel free to add a:

Yours,
	-- Matti