linux-kernel - Re: [PATCH v2 6/6] arm64: dts: qcom: ipq5332: Enable PCIe phys and controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2AOimZhQWrU+1jy@hu-varada-blr.qualcomm.com>
Date: Mon, 16 Dec 2024 16:57:06 +0530
From: Varadarajan Narayanan <quic_varada@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
CC: <lpieralisi@...nel.org>, <kw@...ux.com>,
        <manivannan.sadhasivam@...aro.org>, <robh@...nel.org>,
        <bhelgaas@...gle.com>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <vkoul@...nel.org>, <kishon@...nel.org>, <andersson@...nel.org>,
        <konradybcio@...nel.org>, <p.zabel@...gutronix.de>,
        <quic_nsekar@...cinc.com>, <dmitry.baryshkov@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>,
        "Praveenkumar I" <quic_ipkumar@...cinc.com>
Subject: Re: [PATCH v2 6/6] arm64: dts: qcom: ipq5332: Enable PCIe phys and
 controllers

On Thu, Dec 05, 2024 at 05:58:19PM +0100, Konrad Dybcio wrote:
> On 4.12.2024 12:33 PM, Varadarajan Narayanan wrote:
> > From: Praveenkumar I <quic_ipkumar@...cinc.com>
> >
> > Enable the PCIe controller and PHY nodes for RDP 441.
> >
> > Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
> > Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> > ---
> >  arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts | 74 +++++++++++++++++++++
> >  1 file changed, 74 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> > index 846413817e9a..83eca8435cff 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> > +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> > @@ -62,4 +62,78 @@ data-pins {
> >  			bias-pull-up;
> >  		};
> >  	};
> > +
> > +	pcie0_default: pcie0-default-state {
> > +		clkreq-n-pins {
> > +			pins = "gpio37";
> > +			function = "pcie0_clk";
> > +			drive-strength = <8>;
> > +			bias-pull-up;
> > +		};
> > +
> > +		perst-n-pins {
> > +			pins = "gpio38";
> > +			function = "gpio";
> > +			drive-strength = <8>;
> > +			bias-pull-up;
> > +			output-low;
> > +		};
> > +
> > +		wake-n-pins {
> > +			pins = "gpio39";
> > +			function = "pcie0_wake";
> > +			drive-strength = <8>;
> > +			bias-pull-up;
> > +		};
> > +	};
> > +
> > +	pcie1_default: pcie1-default-state {
> > +		clkreq-n-pins {
> > +			pins = "gpio46";
> > +			function = "pcie1_clk";
> > +			drive-strength = <8>;
> > +			bias-pull-up;
> > +		};
> > +
> > +		perst-n-pins {
> > +			pins = "gpio47";
> > +			function = "gpio";
> > +			drive-strength = <8>;
> > +			bias-pull-up;
> > +			output-low;
> > +		};
> > +
> > +		wake-n-pins {
> > +			pins = "gpio48";
> > +			function = "pcie1_wake";
> > +			drive-strength = <8>;
> > +			bias-pull-up;
> > +		};
> > +	};
> > +};
> > +
> > +&pcie0_phy {
> > +	status = "okay";
> > +};
>
> 'p' < 't', please put this before &tlmm
>
> Also, would this be something to put into rdp-common?
>
> Do we still use all of these variants?
>
> $ ls arch/arm64/boot/dts/qcom/ipq5332-rdp*.dts
>   arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
>   arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts
>   arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
>   arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts

Yes.

Will fix the comments (here and other patches) and post a new version.

Thanks
Varada